Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5099#discussion_r154315071
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java ---
@@ -25,20 +25,9 @@
public class MetricOptions {
/**
- * The list of named reporters. Names are defined here and per-reporter
configs
- * are given with the reporter config prefix and the reporter name.
- *
- * Example:
- * <pre>{@code
- * metrics.reporters = foo, bar
- *
- * metrics.reporter.foo.class =
org.apache.flink.metrics.reporter.JMXReporter
- * metrics.reporter.foo.interval = 10
- *
- * metrics.reporter.bar.class =
org.apache.flink.metrics.graphite.GraphiteReporter
- * metrics.reporter.bar.port = 1337
- * }</pre>
+ * @deprecated This configuration key has no effect.
*/
+ @Deprecated
--- End diff --
This option should only be used by Flink in the setup of reporters, and
tests/user-code to configure reporters. All these cases should continue to work
even with the option being a no-op. The only case that may now fail if some
test was configuring this option but no actual reporter, but well, that will
fail regardless of whether we keep the option or not.
I'd rather keep it to not cause compilation failures.
---
