Github user mxm commented on a diff in the pull request:

    https://github.com/apache/flink/pull/868#discussion_r33340734
  
    --- Diff: tools/create_release_files.sh ---
    @@ -85,37 +87,43 @@ else
     fi
     
     
    +prepare() {
    +  # prepare
    +  git clone http://git-wip-us.apache.org/repos/asf/flink.git flink
    +  cd flink
    +  git checkout -b "$RELEASE_VERSION-$RELEASE_CANDIDATE" 
origin/$RELEASE_BRANCH
    +  rm -f .gitignore
    +  rm -f .travis.yml
    +  rm -f deploysettings.xml
    +  rm -f CHANGELOG
    +}
    +
     # create source package
    -git clone http://git-wip-us.apache.org/repos/asf/flink.git flink
    -cd flink
    -git checkout -b "$RELEASE_VERSION-$RELEASE_CANDIDATE" 
origin/$RELEASE_BRANCH
    -rm -f .gitignore
    -rm -f .travis.yml
    -rm -f deploysettings.xml
    -rm -f CHANGELOG
    -
    -#find . -name 'pom.xml' -type f -exec sed -i 
's#<version>$OLD_VERSION</version>#<version>$NEW_VERSION</version>#' {} \;
    -if [ "$(uname)" == "Darwin" ]; then
    -    find . -name 'pom.xml' -type f -exec sed -i "" 
's#<version>'$OLD_VERSION'</version>#<version>'$NEW_VERSION'</version>#' {} \;
    -else
    -    find . -name 'pom.xml' -type f -exec sed -i    
's#<version>'$OLD_VERSION'</version>#<version>'$NEW_VERSION'</version>#' {} \;
    -fi
    +make_source_release() {
     
    -git commit --author="$GIT_AUTHOR" -am "Commit for release $RELEASE_VERSION"
    -git remote add asf_push 
https://$user_n...@git-wip-us.apache.org/repos/asf/flink.git
    -RELEASE_HASH=`git rev-parse HEAD`
    -echo "Echo created release hash $RELEASE_HASH"
    +  #find . -name 'pom.xml' -type f -exec sed -i 
's#<version>$OLD_VERSION</version>#<version>$NEW_VERSION</version>#' {} \;
    --- End diff --
    
    I think you can remove this line.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to