[
https://issues.apache.org/jira/browse/FLINK-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276612#comment-16276612
]
ASF GitHub Bot commented on FLINK-8191:
---------------------------------------
GitHub user Aegeaner opened a pull request:
https://github.com/apache/flink/pull/5116
[FLINK-8191] [Kafka Connector] Add a RoundRobinPartitioner to be shipped
with the Kafka…
Add a RoundRobinPartitioner to be shipped with the Kafka connector
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of
the pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Travis CI to do that following [this
guide](http://flink.apache.org/contribute-code.html#best-practices).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text
and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
## What is the purpose of the change
We should perhaps consider adding a round-robin partitioner ready for use
to be shipped with the Kafka connector, along side the already available
FlinkFixedPartitioner.
## Brief change log
Add a `FlinkRoundRobinPartitioner` class in
_org.apache.flink.streaming.connectors.kafka.partitioner_ package.
## Verifying this change
Verified by new added unit test `FlinkRoundRobinPartitionerTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (**yes** / no)
- If yes, how is the feature documented? (not applicable / docs /
**JavaDocs** / not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Aegeaner/flink FLINK-8191
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5116.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5116
----
commit 67e07e82895ff680e65b23af06ccb6085f5ae0b6
Author: Aegeaner <[email protected]>
Date: 2017-12-04T10:49:12Z
[FLINK-8191] Add a RoundRobinPartitioner to be shipped with the Kafka
connector
----
> Add a RoundRobinPartitioner to be shipped with the Kafka connector
> ------------------------------------------------------------------
>
> Key: FLINK-8191
> URL: https://issues.apache.org/jira/browse/FLINK-8191
> Project: Flink
> Issue Type: New Feature
> Components: Kafka Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Aegeaner
> Fix For: 1.5.0
>
>
> We should perhaps consider adding a round-robin partitioner ready for use to
> be shipped with the Kafka connector, along side the already available
> {{FlinkFixedPartitioner}}.
> See the original discussion here:
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/FlinkKafkaProducerXX-td16951.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
