Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5098#discussion_r154880974
  
    --- Diff: flink-metrics/flink-metrics-datadog/pom.xml ---
    @@ -88,6 +65,7 @@ under the License.
                                                        <goal>shade</goal>
                                                </goals>
                                                <configuration>
    +                                                   
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
    --- End diff --
    
    This is a cleaner approach compared to listing transitive dependencies. We 
never had a dependency on `okio`; it was only defined to be included in the 
shaded jar. Promoting transitive dependencies accomplishes the same thing, 
without the maintainability issues that arise when you bump the version of a 
dependency.


---

Reply via email to