Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5087#discussion_r155012983
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ---
    @@ -331,8 +334,19 @@ public void setInitialState(TaskStateSnapshot 
checkpointStateHandles) {
         *
         * @return A future for the execution's termination
         */
    -   public CompletableFuture<ExecutionState> getTerminationFuture() {
    -           return terminationFuture;
    +   @Override
    +   public CompletableFuture<ExecutionState> getTerminalStateFuture() {
    +           return terminalStateFuture;
    +   }
    +
    +   /**
    +    * Gets the release future which is completed once the execution 
reaches a terminal
    +    * state and the assigned resource has been released.
    +    *
    +    * @return
    --- End diff --
    
    `@return` tag can be removed.


---

Reply via email to