[
https://issues.apache.org/jira/browse/FLINK-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278883#comment-16278883
]
ASF GitHub Bot commented on FLINK-8085:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5087#discussion_r155015331
--- Diff:
flink-runtime/src/test/java/org/apache/flink/runtime/jobmanager/scheduler/SchedulerIsolatedTasksTest.java
---
@@ -294,11 +297,11 @@ public void testScheduleWithDyingInstances() {
i2.markDead();
- for (SimpleSlot slot : slots) {
- if (slot.getOwner() == i2) {
- assertTrue(slot.isCanceled());
+ for (LogicalSlot slot : slots) {
+ if
(Objects.equals(slot.getTaskManagerLocation().getResourceID(),
i2.getTaskManagerID())) {
--- End diff --
I think `slot.getTaskManagerLocation().getResourceID()` cannot return null.
Is there a need to use `Objects.equals`?
> Thin out the LogicalSlot interface
> ----------------------------------
>
> Key: FLINK-8085
> URL: https://issues.apache.org/jira/browse/FLINK-8085
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Minor
> Labels: flip-6
>
> The {{LogicalSlot}} interface contains method which we don't strictly need
> (e.g. {{isCanceled}}, {{isReleased}}). Moreover, we should decouple the
> {{LogicalSlot}} from the {{Execution}} by only setting the
> {{ExecutionAttemptID}} instead of {{Execution}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
