Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5114#discussion_r155200829
  
    --- Diff: 
flink-mesos/src/main/scala/org/apache/flink/mesos/scheduler/LaunchCoordinator.scala
 ---
    @@ -148,14 +149,17 @@ class LaunchCoordinator(
     
         case Event(offers: ResourceOffers, data: GatherData) =>
           val leases = offers.offers().asScala.map(
    -        new VMLeaseObject(_).asInstanceOf[VirtualMachineLease])
    +        new Offer(_).asInstanceOf[VirtualMachineLease])
    --- End diff --
    
    If I'm not mistaken, then the Scala `Buffer` implements 
`GenTraversableOnce` which is co-variant in its generic type and thus, there is 
no need for downcasting. I'll try it out and if it's possible, then I'll apply 
the changes while merging.


---

Reply via email to