[ https://issues.apache.org/jira/browse/FLINK-8087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16280352#comment-16280352 ]
ASF GitHub Bot commented on FLINK-8087: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5088#discussion_r155276432 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/slots/SlotContext.java --- @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.jobmanager.slots; + +import org.apache.flink.runtime.clusterframework.types.AllocationID; +import org.apache.flink.runtime.instance.Slot; +import org.apache.flink.runtime.taskmanager.TaskManagerLocation; + +/** + * Interface for the context of a logical {@link Slot}. This context contains information + * about the underlying allocated slot and how to communicate with the TaskManager on which + * it was allocated. + */ +public interface SlotContext { + + /** + * Gets the ID under which the slot is allocated, which uniquely identifies the slot. + * + * @return The ID under which the slot is allocated + */ + AllocationID getAllocationId(); + + /** + * Gets the location info of the TaskManager that offers this slot. + * + * @return The location info of the TaskManager that offers this slot + */ + TaskManagerLocation getTaskManagerLocation(); + + /** + * Gets the number of the slot. + * + * @return The number of the slot on the TaskManager. + */ + int getPhysicalSlotNumber(); + + /** + * Gets the actor gateway that can be used to send messages to the TaskManager. + * <p> + * This method should be removed once the new interface-based RPC abstraction is in place + * + * @return The actor gateway that can be used to send messages to the TaskManager. --- End diff -- The fact that `TaskManagerGateway` can be an *actor gateway* is not something that is relevant for the Javadoc. > Decouple Slot from SlotPool > --------------------------- > > Key: FLINK-8087 > URL: https://issues.apache.org/jira/browse/FLINK-8087 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Labels: flip-6 > > In order to let the {{SlotPool}} return a a different {{LogicalSlot}} > implementation than {{SimpleSlot}} we should not store the {{Slot}} inside of > the {{SlotPool}}. Moreover, we should introduce a abstraction for the > {{AllocatedSlot}} which contains the information required by the > {{SimpleSlot}}. That way we decouple the {{SimpleSlot}} from the > {{AllocatedSlot}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)