[ 
https://issues.apache.org/jira/browse/FLINK-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283302#comment-16283302
 ] 

ASF GitHub Bot commented on FLINK-8224:
---------------------------------------

GitHub user shuai-xu opened a pull request:

    https://github.com/apache/flink/pull/5139

    [FLINK-8224] [runtime] shutdown application when job terminated in job mode

    ## What is the purpose of the change
    
    This current job cluster entrypoint doesn't call resource manage to 
shutdown the application. So resource manger has no change to set the 
application status to the outer resource management system such as YARN/Mesos. 
This may make the YARN still consider the application as running even the job 
is finished.
    
    ## Verifying this change
    
    This change is tested manually.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shuai-xu/flink jira-8224

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5139
    
----
commit b047b2a50791f4eeeb4c3a984d060ffdbf57ea26
Author: shuai.xus <shuai....@alibaba-inc.com>
Date:   2017-12-08T10:02:42Z

    [FLINK-8224] [runtime] shutdown application when job terminated in job mode

----


> Should shudownApplication when job terminated in job mode
> ---------------------------------------------------------
>
>                 Key: FLINK-8224
>                 URL: https://issues.apache.org/jira/browse/FLINK-8224
>             Project: Flink
>          Issue Type: Bug
>          Components: Cluster Management
>    Affects Versions: 1.5.0
>            Reporter: shuai.xu
>            Assignee: shuai.xu
>              Labels: flip-6
>
> For job modeļ¼Œ one job is an application. When job finished, it should tell 
> the resource manager to shutdown the application, otherwise the resource 
> manager can not set the application status. For example, if yarn resource 
> manager don't set application as finished to yarn master, the yarn will 
> consider the application as still running.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to