[
https://issues.apache.org/jira/browse/FLINK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284570#comment-16284570
]
ASF GitHub Bot commented on FLINK-8227:
---------------------------------------
GitHub user dianfu opened a pull request:
https://github.com/apache/flink/pull/5142
[FLINK-8227] Optimize the performance of SharedBufferSerializer
## What is the purpose of the change
*This pull request optimize the performance of SharedBufferSerializer*
## Verifying this change
This change is a performance improvement without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dianfu/flink optimize_sharedbuffer
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5142
----
commit b586abec579ef7f251333032c9385d7e71f3799b
Author: Dian Fu <fudian...@alibaba-inc.com>
Date: 2017-12-09T03:51:04Z
[FLINK-8227] Optimize the performance of SharedBufferSerializer
----
> Optimize the performance of SharedBufferSerializer
> --------------------------------------------------
>
> Key: FLINK-8227
> URL: https://issues.apache.org/jira/browse/FLINK-8227
> Project: Flink
> Issue Type: Bug
> Components: CEP
> Reporter: Dian Fu
> Assignee: Dian Fu
>
> Currently {{SharedBufferSerializer.serialize()}} will create a HashMap and
> put all the {{SharedBufferEntry}} into it. Usually this is not a problem. But
> we obverse that in some cases the calculation of hashCode may become the
> bottleneck. The performance will decrease as the number of
> {{SharedBufferEdge}} increases. For looping pattern {{A*}}, if the number of
> {{SharedBufferEntry}} is {{N}}, the number of {{SharedBufferEdge}} is about
> {{N * N}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
