[
https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287327#comment-16287327
]
ASF GitHub Bot commented on FLINK-7468:
---------------------------------------
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/4559
I'd opt for decreasing under the lock as well, or (even better?) the
following alternative:
We remove the `buffersInBacklog` member and return the size of the current
backlog along the `getNextBuffer()` calls just like `BufferAndAvailability` is
returned by the `SequenceNumberingViewReader`. This `getNextBuffer()` call is
under the lock already and (except for `toString()` methods in
`PipelinedSubpartition` and `SpillableSubpartition`) the backlog is only
requested along the `getNextBuffer()` calls.
> Implement sender backlog logic for credit-based
> -----------------------------------------------
>
> Key: FLINK-7468
> URL: https://issues.apache.org/jira/browse/FLINK-7468
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Reporter: zhijiang
> Assignee: zhijiang
> Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> Receivers should know how many buffers are available on the sender side (the
> backlog). The receivers use this information to decide how to distribute
> floating buffers.
> The {{ResultSubpartition}} maintains the backlog which only indicates the
> number of buffers in this subpartition, not including the number of events.
> The backlog is increased for adding buffer to this subpartition, and
> decreased for polling buffer from it.
> The backlog is attached in {{BufferResponse}} by sender as an absolute value
> after the buffer being transferred.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
