[
https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296973#comment-16296973
]
ASF GitHub Bot commented on FLINK-8162:
---------------------------------------
GitHub user casidiablo opened a pull request:
https://github.com/apache/flink/pull/5182
[FLINK-8162] [kinesis-connector] Emit Kinesis' millisBehindLatest metric
## What is the purpose of the change
- Emits [Kinesis'
millisBehindLatest](http://docs.aws.amazon.com/kinesis/latest/APIReference/API_GetRecords.html)
metric, which can be used to detect delays in the pipeline
## Brief change log
- Publish `millisBehindLatest` as a gauge metric under the `Kinesis`
group using `<shard_id>` as parameter
- Updated metrics documentation
## Verifying this change
This change is already covered by existing tests, such as
`ShardConsumerTest`.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? yes
- If yes, how is the feature documented? `metrics.md` file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/casidiablo/flink kinesis-fork
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5182.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5182
----
commit bc8426ec3be364323d65cedcc1c1c5cb4e442c8b
Author: Cristian <m...@cristian.io>
Date: 2017-12-19T15:14:22Z
Emit Kinesis' millisBehindLatest metric
----
> Kinesis Connector to report millisBehindLatest metric
> -----------------------------------------------------
>
> Key: FLINK-8162
> URL: https://issues.apache.org/jira/browse/FLINK-8162
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Reporter: Cristian
> Priority: Minor
> Labels: kinesis
> Fix For: 1.5.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> When reading from Kinesis streams, one of the most valuable metrics is
> "MillisBehindLatest" (see
> https://github.com/aws/aws-sdk-java/blob/25f0821f69bf94ec456f602f2b83ea2b0ca15643/aws-java-sdk-kinesis/src/main/java/com/amazonaws/services/kinesis/model/GetRecordsResult.java#L187-L201).
> Flink should use its metrics mechanism to report this value as a gauge,
> tagging it with the shard id.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
