[ 
https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297436#comment-16297436
 ] 

ASF GitHub Bot commented on FLINK-8234:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5184#discussion_r157876793
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/RestfulGateway.java
 ---
    @@ -92,4 +94,42 @@
         * @return Future containing the collection of instance ids and the 
corresponding metric query service path
         */
        CompletableFuture<Collection<Tuple2<ResourceID, String>>> 
requestTaskManagerMetricQueryServicePaths(@RpcTimeout Time timeout);
    +
    +   /**
    +    * Returns the {@link SerializedJobExecutionResult} for a job, or in 
case the job failed, the
    +    * failure cause.
    +    *
    +    * @param jobId ID of the job that we are interested in.
    +    * @param timeout Timeout for the asynchronous operation.
    +    *
    +    * @see #isJobExecutionResultPresent(JobID, Time)
    +    *
    +    * @return {@link CompletableFuture} containing the {@link 
JobExecutionResult} or a
    +    * {@link Throwable} which represents the failure cause. If there is no 
result, the future will
    +    * be completed exceptionally with
    +    * {@link 
org.apache.flink.runtime.messages.JobExecutionResultNotFoundException}
    +    */
    +   default CompletableFuture<JobExecutionResult> getJobExecutionResult(
    +                   JobID jobId,
    +                   @RpcTimeout Time timeout) {
    +           throw new UnsupportedOperationException();
    +   }
    +
    +   /**
    +    * Tests if the {@link SerializedJobExecutionResult} is present.
    --- End diff --
    
    Javadoc needs to be updated.


> Cache JobExecutionResult from finished JobManagerRunners
> --------------------------------------------------------
>
>                 Key: FLINK-8234
>                 URL: https://issues.apache.org/jira/browse/FLINK-8234
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Gary Yao
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> In order to serve the {{JobExecutionResults}} we have to cache them in the 
> {{Dispatcher}} after the {{JobManagerRunner}} has finished. The cache should 
> have a configurable size and should periodically clean up stale entries in 
> order to avoid memory leaks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to