[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298092#comment-16298092 ]
ASF GitHub Bot commented on FLINK-8234: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157963387 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java --- @@ -405,22 +407,27 @@ private void decrementCheckAndCleanup() { private volatile Throwable runnerException; - private volatile JobExecutionResult result; + private volatile org.apache.flink.runtime.jobmaster.JobExecutionResult result; BlockingJobSync(JobID jobId, int numJobMastersToWaitFor) { this.jobId = jobId; this.jobMastersToWaitFor = new CountDownLatch(numJobMastersToWaitFor); } @Override - public void jobFinished(JobExecutionResult jobResult) { - this.result = jobResult; + public void jobFinished(org.apache.flink.runtime.jobmaster.JobExecutionResult result) { + this.result = result; jobMastersToWaitFor.countDown(); } @Override - public void jobFailed(Throwable cause) { - jobException = cause; + public void jobFailed(org.apache.flink.runtime.jobmaster.JobExecutionResult result) { + checkArgument(result.getSerializedThrowable().isPresent()); + + jobException = result --- End diff -- Actually it is not needed to store the exception separately because the JobExecutionResult already contains the exception. > Cache JobExecutionResult from finished JobManagerRunners > -------------------------------------------------------- > > Key: FLINK-8234 > URL: https://issues.apache.org/jira/browse/FLINK-8234 > Project: Flink > Issue Type: Sub-task > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Gary Yao > Priority: Blocker > Labels: flip-6 > Fix For: 1.5.0 > > > In order to serve the {{JobExecutionResults}} we have to cache them in the > {{Dispatcher}} after the {{JobManagerRunner}} has finished. The cache should > have a configurable size and should periodically clean up stale entries in > order to avoid memory leaks. -- This message was sent by Atlassian JIRA (v6.4.14#64029)