[ 
https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298177#comment-16298177
 ] 

ASF GitHub Bot commented on FLINK-8289:
---------------------------------------

GitHub user shuai-xu opened a pull request:

    https://github.com/apache/flink/pull/5190

    [FLINK-8289] [runtime] set the rest.address to the host of the rest server 
machine

    
    ## What is the purpose of the change
    
    This pull request set the rest.address to the host of the Dispatcher or 
JobMaster, so that the real address of the rest server instead of 0.0.0.0:9067 
or 127.0.0.0:9067.
    
    
    
    ## Verifying this change
    
    This change is tested manually.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shuai-xu/flink jira-8289

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5190
    
----
commit 0956b94a910df071a61aae90cac7fef2b795ed0c
Author: shuai.xus <shuai.xus@...>
Date:   2017-12-20T09:37:10Z

    [FLINK-8289] [runtime] set the rest.address to the host of the rest server 
machine

----


> The RestServerEndpoint should return the address with real ip when 
> getRestAdddress
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-8289
>                 URL: https://issues.apache.org/jira/browse/FLINK-8289
>             Project: Flink
>          Issue Type: Bug
>    Affects Versions: 1.5.0
>            Reporter: shuai.xu
>              Labels: flip-6
>
> Now when RestServerEndpoint.getRestAddress, it will return an address same 
> with the value of config rest.address, the default it 127.0.0.1:9067, but 
> this address can not be accessed from another machine. And the ip for 
> Dispatcher and JobMaster are usually dynamically, so user will configure it 
> to 0.0.0.0, and the getRestAddress will return 0.0.0.0:9067, this address 
> will be registered to YARN or Mesos, but this address can not be accessed 
> from another machine also. So it need to return the real ip:port for user to 
> access the web monitor anywhere.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to