[
https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298598#comment-16298598
]
ASF GitHub Bot commented on FLINK-8079:
---------------------------------------
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/5156#discussion_r158037581
--- Diff: tools/travis_mvn_watchdog.sh ---
@@ -543,35 +543,45 @@ case $TEST in
printf "Running end-to-end tests\n"
printf
"==============================================================================\n"
- printf
"\n==============================================================================\n"
- printf "Running Wordcount end-to-end test\n"
- printf
"==============================================================================\n"
- FLINK_DIR=build-target CLUSTER_MODE=cluster
test-infra/end-to-end-test/test_batch_wordcount.sh
- EXIT_CODE=$(($EXIT_CODE+$?))
-
- printf
"\n==============================================================================\n"
- printf "Running Kafka end-to-end test\n"
- printf
"==============================================================================\n"
- FLINK_DIR=build-target CLUSTER_MODE=cluster
test-infra/end-to-end-test/test_streaming_kafka010.sh
- EXIT_CODE=$(($EXIT_CODE+$?))
-
- printf
"\n==============================================================================\n"
- printf "Running class loading end-to-end test\n"
- printf
"==============================================================================\n"
- FLINK_DIR=build-target CLUSTER_MODE=cluster
test-infra/end-to-end-test/test_streaming_classloader.sh
- EXIT_CODE=$(($EXIT_CODE+$?))
-
- printf
"\n==============================================================================\n"
- printf "Running Shaded Hadoop S3A end-to-end test\n"
- printf
"==============================================================================\n"
- FLINK_DIR=build-target CLUSTER_MODE=cluster
test-infra/end-to-end-test/test_shaded_hadoop_s3a.sh
- EXIT_CODE=$(($EXIT_CODE+$?))
-
- printf
"\n==============================================================================\n"
- printf "Running Shaded Presto S3 end-to-end test\n"
- printf
"==============================================================================\n"
- FLINK_DIR=build-target CLUSTER_MODE=cluster
test-infra/end-to-end-test/test_shaded_presto_s3.sh
- EXIT_CODE=$(($EXIT_CODE+$?))
+ if [ $EXIT_CODE == 0 ]; then
+ printf
"\n==============================================================================\n"
+ printf "Running Wordcount end-to-end test\n"
+ printf
"==============================================================================\n"
+ FLINK_DIR=build-target CLUSTER_MODE=cluster
test-infra/end-to-end-test/test_batch_wordcount.sh
+ EXIT_CODE=$(($EXIT_CODE+$?))
--- End diff --
If `$EXIT_CODE == 0` then why not simply set `EXIT_CODE=$?`?
> Skip remaining E2E tests if one failed
> --------------------------------------
>
> Key: FLINK-8079
> URL: https://issues.apache.org/jira/browse/FLINK-8079
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.5.0, 1.4.1
>
>
> I propose that if one end-to-end tests fails the remaining tests are skipped.
> [~aljoscha] What do you think?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
