[ 
https://issues.apache.org/jira/browse/FLINK-8312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302350#comment-16302350
 ] 

ASF GitHub Bot commented on FLINK-8312:
---------------------------------------

GitHub user Xpray opened a pull request:

    https://github.com/apache/flink/pull/5206

    [FLINK-8312][TableAPI && SQL] Fix ScalarFunction varargs length excee…

    
    
    ## What is the purpose of the change
    
    *Support parameters exceeds 254 with Varargs for SQL*
    
    
    ## Brief change log
    
      - *if scalar function is varargs, do not check parameter length, set max 
length to -1*
    
    
    ## Verifying this change
    
    
    
    This change added tests and can be verified as follows:
    
    *(example:)*
      - *SqlITCase.testUDFWithLongVarargs*
    
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): no
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
      - The serializers: no
      - The runtime per-record code paths (performance sensitive): no
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
      - The S3 file system connector: no
    
    ## Documentation
    
      - Does this pull request introduce a new feature? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Xpray/flink FLINK-8312

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5206.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5206
    
----
commit 4de1200791193163e5ade21cdfb1160e3894342d
Author: Xpray <leonxpray@...>
Date:   2017-12-23T10:52:29Z

    [FLINK-8312][TableAPI && SQL] Fix ScalarFunction varargs length exceeds 254 
for SQL

----


> Fix ScalarFunction varargs length exceeds 254 for SQL
> -----------------------------------------------------
>
>                 Key: FLINK-8312
>                 URL: https://issues.apache.org/jira/browse/FLINK-8312
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>
> With Varargs, TableAPI can handle scalar function call with parameters 
> exceeds 254 correctly.
> This issue is intend to support long parameters for SQL



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to