[ 
https://issues.apache.org/jira/browse/FLINK-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16302443#comment-16302443
 ] 

ASF GitHub Bot commented on FLINK-8301:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5203#discussion_r158582395
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/stream/sql/SqlITCase.scala
 ---
    @@ -481,4 +484,48 @@ class SqlITCase extends StreamingWithStateTestBase {
         assertEquals(expected.sorted, MemoryTableSinkUtil.results.sorted)
       }
     
    +  @Test
    +  def testUnicodeParameter(): Unit = {
    +    val data = new mutable.MutableList[(String, String, String)]
    +    data.+=((null, null, null)) //""
    --- End diff --
    
    Remove useless comment or say more detail about this test row data.


> Support Unicode in codegen for SQL && TableAPI
> ----------------------------------------------
>
>                 Key: FLINK-8301
>                 URL: https://issues.apache.org/jira/browse/FLINK-8301
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Ruidong Li
>            Assignee: Ruidong Li
>
> The current code generation do not support Unicode, "\u0001" will be 
> generated to "\\u0001", function call like concat(str, "\u0001") will lead to 
> wrong result.
> This issue intend to handle char/varchar literal correctly, some examples 
> followed as below.
> literal: '\u0001abc'    ->   codegen:  "\u0001abc"
> literal: '\u0022\'         ->   codegen:  "\"\\"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to