Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5215#discussion_r159227955
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
    @@ -660,7 +570,25 @@ public int run(
                                        "yarn application -kill " + 
applicationId.getOpt());
                                yarnCluster.disconnect();
                        } else {
    -                           runInteractiveCli(yarnCluster, true);
    +                           ScheduledThreadPoolExecutor 
scheduledExecutorService = new ScheduledThreadPoolExecutor(1);
    --- End diff --
    
    I think the executor could as well be in the Monitor. If needed in the 
future, one could provide a constructor that accepts an external executor 
(e.g., for unit tests).


---

Reply via email to