Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5193#discussion_r159222250
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/TaskTestBase.java
 ---
    @@ -145,19 +145,7 @@ public MemoryManager getMemoryManager() {
        }
     
        @After
    -   public void shutdownIOManager() throws Exception {
    -           this.mockEnv.getIOManager().shutdown();
    -           Assert.assertTrue("IO Manager has not properly shut down.", 
this.mockEnv.getIOManager().isProperlyShutDown());
    -   }
    -
    -   @After
    -   public void shutdownMemoryManager() throws Exception {
    -           if (this.memorySize > 0) {
    --- End diff --
    
    No, it didn't matter so I allowed myself to simplify this shutdown. But 
good catch. I was thinking about doing this simplification in separate commit 
so that there would be no need for "catching" this behaviour change. 


---

Reply via email to