[ https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308184#comment-16308184 ]
ASF GitHub Bot commented on FLINK-8329: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5216#discussion_r159242946 --- Diff: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java --- @@ -78,6 +83,9 @@ public void testPerJobMode() { jobGraph.addJar(new org.apache.flink.core.fs.Path(testingJar.toURI())); YarnClusterClient clusterClient = yarnClusterDescriptorV2.deployJobCluster(clusterSpecification, jobGraph); + + clusterClient.shutdown(); + yarnClusterDescriptorV2.close(); --- End diff -- Closing in finally or try-with-resource not needed? > Move YarnClient out of YarnClusterClient > ---------------------------------------- > > Key: FLINK-8329 > URL: https://issues.apache.org/jira/browse/FLINK-8329 > Project: Flink > Issue Type: Sub-task > Components: Client > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Labels: flip-6 > Fix For: 1.5.0 > > > Move the {{YarnClient}} from the {{YarnClusterClient}} to the > {{AbstractYarnClusterDescriptor}} which will be responsible for the lifecycle > management of the {{YarnClient}}. This change is a clean up task which will > better structure the client code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)