[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313567#comment-16313567 ]
ASF GitHub Bot commented on FLINK-8175: --------------------------------------- Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/5112#discussion_r159941955 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/experimental/CollectSink.java --- @@ -28,8 +29,12 @@ import java.net.Socket; /** - * A specialized data sink to be used by DataStreamUtils.collect. + * A specialized data sink to be used by DataStreamUtils.collect(). + * + * <p>This experimental class is relocated from flink-streaming-contrib. Please see package-info.java + * for more information. */ +@PublicEvolving --- End diff -- Would this better be `@Internal`? I think it is not meant to be instantiated directly, but only via the collect() call... > remove flink-streaming-contrib and migrate its classes to > flink-streaming-java/scala > ------------------------------------------------------------------------------------ > > Key: FLINK-8175 > URL: https://issues.apache.org/jira/browse/FLINK-8175 > Project: Flink > Issue Type: Sub-task > Affects Versions: 1.5.0 > Reporter: Bowen Li > Assignee: Bowen Li > Fix For: 1.5.0 > > > I propose removing flink-streaming-contrib from flink-contrib, and migrating > its classes to flink-streaming-java/scala for the following reasons: > - flink-streaming-contrib is so small that it only has 4 classes (3 java and > 1 scala), and they don't need a dedicated jar for Flink to distribute and > maintain it and for users to deal with the overhead of dependency management > - the 4 classes in flink-streaming-contrib are logically more tied to > flink-streaming-java/scala, and thus can be easily migrated > - flink-contrib is already too crowded and noisy. It contains lots of sub > modules with different purposes which confuse developers and users, and they > lack a proper project hierarchy > To take a step even forward, I would argue that even flink-contrib should be > removed and all its submodules should be migrated to other top-level modules > for the following reasons: 1) Apache Flink the whole project itself is a > result of contributions from many developers, there's no reason to highlight > some contributions in a dedicated module named 'contrib' 2) flink-contrib > inherently doesn't have a good hierarchy to hold submodules -- This message was sent by Atlassian JIRA (v6.4.14#64029)