[
https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316081#comment-16316081
]
ASF GitHub Bot commented on FLINK-8234:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/5184#discussion_r160114353
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/JobExecutionResultCache.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.dispatcher;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.runtime.jobmaster.JobExecutionResult;
+
+import org.apache.flink.shaded.guava18.com.google.common.cache.Cache;
+import
org.apache.flink.shaded.guava18.com.google.common.cache.CacheBuilder;
+
+import javax.annotation.Nullable;
+
+import java.util.concurrent.TimeUnit;
+
+import static org.apache.flink.util.Preconditions.checkState;
+
+/**
+ * Caches {@link JobExecutionResult}s.
+ */
+class JobExecutionResultCache {
+
+ private static final int MAX_RESULT_CACHE_DURATION_SECONDS = 300;
+
+ private final Cache<JobID, JobExecutionResult>
+ jobExecutionResultCache =
+ CacheBuilder.newBuilder()
+ .softValues()
--- End diff --
I assume that we use a LRU strategy if we hit the maximum size. But what
happens if we purged a job result and then a client asks for it. We should
return then at least something like the job finished but the execution result
couldn't be stored.
> Cache JobExecutionResult from finished JobManagerRunners
> --------------------------------------------------------
>
> Key: FLINK-8234
> URL: https://issues.apache.org/jira/browse/FLINK-8234
> Project: Flink
> Issue Type: Sub-task
> Components: Distributed Coordination
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Gary Yao
> Priority: Blocker
> Labels: flip-6
> Fix For: 1.5.0
>
>
> In order to serve the {{JobExecutionResults}} we have to cache them in the
> {{Dispatcher}} after the {{JobManagerRunner}} has finished. The cache should
> have a configurable size and should periodically clean up stale entries in
> order to avoid memory exhaustion.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
