[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318198#comment-16318198 ]
ASF GitHub Bot commented on FLINK-7511: --------------------------------------- Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r160349688 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java --- @@ -150,16 +126,13 @@ */ private boolean nfaChanged; - public NFA( - final TypeSerializer<T> eventSerializer, + public NFA(final TypeSerializer<T> eventSerializer, final long windowTime, final boolean handleTimeout) { - this.eventSerializer = eventSerializer; --- End diff -- shouldn't the `eventSerializer` be checked for not null here after this change? > Remove dead code after dropping backward compatibility with <=1.2 > ----------------------------------------------------------------- > > Key: FLINK-7511 > URL: https://issues.apache.org/jira/browse/FLINK-7511 > Project: Flink > Issue Type: Improvement > Components: CEP > Affects Versions: 1.4.0 > Reporter: Dawid Wysakowicz > Assignee: Dawid Wysakowicz > -- This message was sent by Atlassian JIRA (v6.4.14#64029)