Github user hsaputra commented on a diff in the pull request:

    https://github.com/apache/flink/pull/876#discussion_r33604696
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/FlinkYarnClient.java ---
    @@ -341,7 +342,7 @@ public AbstractFlinkYarnCluster run() throws Exception {
         * This method will block until the ApplicationMaster/JobManager have 
been
         * deployed on YARN.
         */
    -   protected AbstractFlinkYarnCluster deployInternal(String clusterName) 
throws Exception {
    +   protected AbstractFlinkYarnCluster deployInternal(String defaultName) 
throws Exception {
    --- End diff --
    
    Since this becomes default, maybe we could just remove the input argument 
and set default internally if customName is null or empty.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to