[ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320578#comment-16320578 ]
ASF GitHub Bot commented on FLINK-5823: --------------------------------------- Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5248#discussion_r160630316 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.configuration; + +/** + * A collection of all configuration options that relate to checkpoints + * and savepoints. + */ +public class CheckpointingOptions { + + // ------------------------------------------------------------------------ + // general checkpoint and state backend options + // ------------------------------------------------------------------------ + + public static final ConfigOption<String> STATE_BACKEND = ConfigOptions + .key("state.backend") + .noDefaultValue(); + + /** The maximum number of completed checkpoint instances to retain.*/ + public static final ConfigOption<Integer> MAX_RETAINED_CHECKPOINTS = ConfigOptions + .key("state.checkpoints.num-retained") + .defaultValue(1); + + // ------------------------------------------------------------------------ + // Options specific to the file-system-based state backends + // ------------------------------------------------------------------------ + + /** The default directory for savepoints. Used by the state backends that write + * savepoints to file systems (MemoryStateBackend, FsStateBackend, RocksDBStateBackend). */ + public static final ConfigOption<String> SAVEPOINT_DIRECTORY = ConfigOptions + .key("state.savepoints.dir") + .noDefaultValue() + .withDeprecatedKeys("savepoints.state.backend.fs.dir"); + + /** The default directory used for checkpoints. Used by the state backends that write + * checkpoints to file systems (MemoryStateBackend, FsStateBackend, RocksDBStateBackend). */ + public static final ConfigOption<String> CHECKPOINTS_DIRECTORY = ConfigOptions + .key("state.checkpoints.dir") + .noDefaultValue(); + + /** Option whether the heap-based key/value data structures should use an asynchronous + * snapshot method. Used by MemoryStateBackend and FsStateBackend. */ + public static final ConfigOption<Boolean> HEAP_KV_ASYNC_SNAPSHOTS = ConfigOptions + .key("state.backend.heap.async") --- End diff -- I wonder if it could make sense to not scope options like async or incremental per backend, just having them as a general switch that backends may or may not support. We could log if a backend choses to ignore a configuration because does not support it. > Store Checkpoint Root Metadata in StateBackend (not in HA custom store) > ----------------------------------------------------------------------- > > Key: FLINK-5823 > URL: https://issues.apache.org/jira/browse/FLINK-5823 > Project: Flink > Issue Type: Sub-task > Components: State Backends, Checkpointing > Reporter: Stephan Ewen > Assignee: Stephan Ewen > Priority: Blocker > Fix For: 1.5.0 > > -- This message was sent by Atlassian JIRA (v6.4.14#64029)