[ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323697#comment-16323697 ]
ASF GitHub Bot commented on FLINK-7511: --------------------------------------- Github user dawidwys commented on a diff in the pull request: https://github.com/apache/flink/pull/4587#discussion_r161163221 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/pattern/AndFilterFunction.java --- @@ -1,55 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package org.apache.flink.cep.pattern; - -import org.apache.flink.api.common.functions.FilterFunction; - -/** - * A filter function which combines two filter functions with a logical and. Thus, the filter - * function only returns true, iff both filters return true. - * - * @param <T> Type of the element to filter - * @deprecated This is only used when migrating from an older Flink version. - * Use the {@link org.apache.flink.cep.pattern.conditions.AndCondition} instead. - */ -@Deprecated -public class AndFilterFunction<T> implements FilterFunction<T> { --- End diff -- I am for dropping support for 1.2. The only problem is regarding the 3rd point in @kl0u list. It is not possible to migrate 1.2 -> 1.4. Neither directly nor through 1.3.2. (that's what I was trying to say in my previous comment). I would be for dropping support for <= 1.2 completely, if it is ok with you > Remove dead code after dropping backward compatibility with <=1.2 > ----------------------------------------------------------------- > > Key: FLINK-7511 > URL: https://issues.apache.org/jira/browse/FLINK-7511 > Project: Flink > Issue Type: Improvement > Components: CEP > Affects Versions: 1.4.0 > Reporter: Dawid Wysakowicz > Assignee: Dawid Wysakowicz > -- This message was sent by Atlassian JIRA (v6.4.14#64029)