Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5223#discussion_r161242245 --- Diff: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java --- @@ -294,44 +306,108 @@ public void testSubmitJobAndWaitForExecutionResult() throws Exception { @Test public void testTriggerSavepoint() throws Exception { - String targetSavepointDirectory = "/alternate"; - TestSavepointTriggerHandler triggerHandler = new TestSavepointTriggerHandler(targetSavepointDirectory); - try (TestRestServerEndpoint ignored = createRestServerEndpoint(triggerHandler)) { + final String targetSavepointDirectory = "/tmp"; + final TestSavepointHandlers testSavepointHandlers = new TestSavepointHandlers(); + final TestSavepointHandlers.TestSavepointTriggerHandler triggerHandler = + testSavepointHandlers.new TestSavepointTriggerHandler( + Arrays.asList(null, targetSavepointDirectory, null).iterator()); + final TestSavepointHandlers.TestSavepointHandler savepointHandler = + testSavepointHandlers.new TestSavepointHandler(Arrays.asList( + new SavepointResponseBody(QueueStatus.completed(), new SavepointInfo( + testSavepointHandlers.testSavepointTriggerId, + "/other/savepoint-0d2fb9-8d5e0106041a", + null)), + new SavepointResponseBody(QueueStatus.completed(), new SavepointInfo( + testSavepointHandlers.testSavepointTriggerId, + "/tmp/savepoint-0d2fb9-8d5e0106041a", + null)), + new SavepointResponseBody(QueueStatus.completed(), new SavepointInfo( + testSavepointHandlers.testSavepointTriggerId, + null, + new SerializedThrowable(new RuntimeException("expected"))))).iterator()); + try (TestRestServerEndpoint ignored = createRestServerEndpoint( + triggerHandler, + savepointHandler)) { + JobID id = new JobID(); { CompletableFuture<String> savepointPathFuture = restClusterClient.triggerSavepoint(id, null); String savepointPath = savepointPathFuture.get(); - Assert.assertEquals("/universe", savepointPath); + assertEquals("/other/savepoint-0d2fb9-8d5e0106041a", savepointPath); --- End diff -- done
---