[ 
https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326792#comment-16326792
 ] 

ASF GitHub Bot commented on FLINK-7456:
---------------------------------------

Github user zhijiangW commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r161667234
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskCancelAsyncProducerConsumerITCase.java
 ---
    @@ -84,7 +84,7 @@ public void testCancelAsyncProducerAndConsumer() throws 
Exception {
                        
config.setInteger(ConfigConstants.LOCAL_NUMBER_TASK_MANAGER, 1);
                        
config.setInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, 1);
                        
config.setInteger(TaskManagerOptions.MEMORY_SEGMENT_SIZE, 4096);
    -                   
config.setInteger(TaskManagerOptions.NETWORK_NUM_BUFFERS, 8);
    +                   
config.setInteger(TaskManagerOptions.NETWORK_NUM_BUFFERS, 16);
    --- End diff --
    
    yes, i will set 9 for it.


> Implement Netty sender incoming pipeline for credit-based
> ---------------------------------------------------------
>
>                 Key: FLINK-7456
>                 URL: https://issues.apache.org/jira/browse/FLINK-7456
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Major
>             Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> On sender side, each subpartition view maintains an atomic integer 
> {{currentCredit}} from receiver. Once receiving the messages of 
> {{PartitionRequest}} and {{AddCredit}}, the {{currentCredit}} is added by 
> deltas.
> Each view also maintains an atomic boolean field to mark it as registered 
> available for transfer to make sure it is enqueued in handler only once. If 
> the {{currentCredit}} increases from zero and there are available buffers in 
> the subpartition, the corresponding view will be enqueued for transferring 
> data.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to