[
https://issues.apache.org/jira/browse/FLINK-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16330809#comment-16330809
]
ASF GitHub Bot commented on FLINK-8037:
---------------------------------------
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/5205
@StephanEwen of the five occurrences in `MemoryManager`,
`ChannelWriterOutputView`, and `InPlaceMutableHashTable` only one occurs in a
function that is called elsewhere. How would you write the tests without
actually allocating the memory required for overflow? I'm fine dropping this PR
if you don't feel this is improving the code quality.
> Missing cast in integer arithmetic in
> TransactionalIdsGenerator#generateIdsToAbort
> ----------------------------------------------------------------------------------
>
> Key: FLINK-8037
> URL: https://issues.apache.org/jira/browse/FLINK-8037
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Greg Hogan
> Priority: Minor
>
> {code}
> public Set<String> generateIdsToAbort() {
> Set<String> idsToAbort = new HashSet<>();
> for (int i = 0; i < safeScaleDownFactor; i++) {
> idsToAbort.addAll(generateIdsToUse(i * poolSize *
> totalNumberOfSubtasks));
> {code}
> The operands are integers where generateIdsToUse() expects long parameter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
