[GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...

[tillrohrmann]

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5312#discussion_r162687806
  
    --- Diff: 
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
    @@ -285,13 +289,45 @@ private static String createMessageHtmlEntry(Class<?> 
messageClass, Class<?> emp
                }
     
                private DocumentingDispatcherRestEndpoint() {
    -                   super(restConfig, dispatcherGatewayRetriever, config, 
handlerConfig, resourceManagerGatewayRetriever, executor, 
metricQueryServiceRetriever);
    +                   super(restConfig, dispatcherGatewayRetriever, config, 
handlerConfig, resourceManagerGatewayRetriever, executor, 
metricQueryServiceRetriever, NoOpElectionService.INSTANCE, 
NoOpFatalErrorHandler.INSTANCE);
                }
     
                @Override
                public List<Tuple2<RestHandlerSpecification, 
ChannelInboundHandler>> initializeHandlers(CompletableFuture<String> 
restAddressFuture) {
                        return super.initializeHandlers(restAddressFuture);
                }
    +
    +           private enum NoOpElectionService implements 
LeaderElectionService {
    --- End diff --
    
    Nice, didn't know about this technique :-)


---