Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/5240#discussion_r162994182 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/descriptors/ConnectorDescriptor.scala --- @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.descriptors + +import org.apache.flink.table.descriptors.DescriptorUtils.connector + +/** + * Describes a connector to an other system. + * + * @param tpe string identifier for the connector + */ +abstract class ConnectorDescriptor(private val tpe: String) extends Descriptor { --- End diff -- Should a `ConnectorDescriptor` know whether it requires an encoding? For example a file descriptor needs an encoding but a JDBC connector doesn't. This property would then be used to validate the configuration
---