[GitHub] flink pull request #5346: [FLINK-8490] [mesos] Allow custom docker parameter...

[joerg84]

Github user joerg84 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5346#discussion_r163483150
  
    --- Diff: 
flink-mesos/src/test/java/org/apache/flink/mesos/runtime/clusterframework/MesosTaskManagerParametersTest.java
 ---
    @@ -84,6 +84,35 @@ public void testContainerVolumes() throws Exception {
                assertEquals(Protos.Volume.Mode.RO, 
params.containerVolumes().get(0).getMode());
        }
     
    +   @Test
    +   public void testContainerDockerParameter() throws Exception {
    +           Configuration config = new Configuration();
    +           
config.setString(MesosTaskManagerParameters.MESOS_RM_CONTAINER_DOCKER_PARAMETERS,
 "testKey=testValue");
    +
    +           MesosTaskManagerParameters params = 
MesosTaskManagerParameters.create(config);
    +           assertEquals(params.dockerParameters().get(0).getKey(), 
"testKey");
    --- End diff --
    
    maybe check the size first, same below.


---