[ https://issues.apache.org/jira/browse/FLINK-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337704#comment-16337704 ]
ASF GitHub Bot commented on FLINK-8450: --------------------------------------- Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5309#discussion_r163549462 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -331,13 +331,13 @@ public void start() throws Exception { } @Override - public CompletableFuture<AccessExecutionGraph> requestJob(JobID jobId, Time timeout) { + public CompletableFuture<ArchivedExecutionGraph> requestJob(JobID jobId, Time timeout) { --- End diff -- nit: The git commit message is wrong: *Let JobMasterGateway#requestJob and DispatcherGateway#requestJob return a CompletableFuture\<SerializableExecutionGraph\>* > Make JobMaster/DispatcherGateway#requestJob type safe > ----------------------------------------------------- > > Key: FLINK-8450 > URL: https://issues.apache.org/jira/browse/FLINK-8450 > Project: Flink > Issue Type: Improvement > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Minor > Labels: flip-6 > Fix For: 1.5.0 > > > Currently, the {{RestfulGateway#requestJob}} returns a > {{CompletableFuture<AccessExecutionGraph>}}. Since {{AccessExecutionGraph}} > is non serializable it could fail if we execute this RPC from a remote > system. In order to make it typesafe we should change its signature to > {{SerializableExecutionGraph}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)