[
https://issues.apache.org/jira/browse/FLINK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339568#comment-16339568
]
ASF GitHub Bot commented on FLINK-8453:
---------------------------------------
Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r163911570
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -486,11 +510,22 @@ private void onFatalError(Throwable throwable) {
fatalErrorHandler.onFatalError(throwable);
}
- private void jobReachedGloballyTerminalState(AccessExecutionGraph
accessExecutionGraph) {
- final JobResult jobResult =
JobResult.createFrom(accessExecutionGraph);
+ private void jobReachedGloballyTerminalState(ArchivedExecutionGraph
archivedExecutionGraph) {
+
Preconditions.checkArgument(archivedExecutionGraph.getState().isGloballyTerminalState(),
"");
--- End diff --
The `errorMessage` is an empty string. Leave it out completely or put
something meaningful.
> Add SerializableExecutionGraphStore to Dispatcher
> -------------------------------------------------
>
> Key: FLINK-8453
> URL: https://issues.apache.org/jira/browse/FLINK-8453
> Project: Flink
> Issue Type: Improvement
> Components: Distributed Coordination, REST
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
> Priority: Major
> Labels: flip-6
> Fix For: 1.5.0
>
>
> The {{Dispatcher}} should have a {{SerializableExecutionGraphStore}} which it
> can use to store completed jobs. This store can then be used to serve
> historic job requests from the web UI, for example. The default
> implementation should persist the jobs to disk and evict the in memory
> instances once they grow to big in order to avoid memory leaks. Additionally,
> the store should expire elements from disk after a user defined time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
