Github user GJL commented on a diff in the pull request:
https://github.com/apache/flink/pull/5310#discussion_r163911570
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
@@ -486,11 +510,22 @@ private void onFatalError(Throwable throwable) {
fatalErrorHandler.onFatalError(throwable);
}
- private void jobReachedGloballyTerminalState(AccessExecutionGraph
accessExecutionGraph) {
- final JobResult jobResult =
JobResult.createFrom(accessExecutionGraph);
+ private void jobReachedGloballyTerminalState(ArchivedExecutionGraph
archivedExecutionGraph) {
+
Preconditions.checkArgument(archivedExecutionGraph.getState().isGloballyTerminalState(),
"");
--- End diff --
The `errorMessage` is an empty string. Leave it out completely or put
something meaningful.
---
