GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/5371

    [FLINK-8357] [conf] Enable rolling in default log settings

    ## What is the purpose of the change
    
    *Enable rolling in default log settings.*
    
    ## Brief change log
    
      - *Change log4j-cli.properties default log ```FileAppender``` to 
```DailyRollingFileAppender```, also did in log4j.properties file.*
      - *Change logback ```logback-yarn.xml``` and ```logback.xml```  default 
FileAppender to  ```RollingFileAppender```.*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
      - The serializers: ( no )
      - The runtime per-record code paths (performance sensitive): (don't know)
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (not documented)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-8357

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5371.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5371
    
----
commit b5f452db5245c34f797b1951b78ff013266b89c9
Author: zhangminglei <zml13856086071@...>
Date:   2018-01-26T09:48:42Z

    [FLINK-8357] [conf] Enable rolling in default log settings

----


---

Reply via email to