GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/5373

    [FLINK-8230] [orc] Fix NPEs when reading nested columns.

    ## What is the purpose of the change
    
    - fixes NPEs for null-valued structs, lists, and maps
    - fixes NPEs for repeating structs, lists, and maps
    
    ## Brief change log
    
    - renamed `OrcUtils` to `OrcBatchReader`
    - reimplement large parts of the `OrcBatchReader`
    - add tests for nested columns with nulls and repeating values
    - added a class to generate ORC files for tests
    
    ## Verifying this change
    
    - added tests to `OrcInputFormatTest`
    - changes have been verified by a user on a production dataset.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **n/a**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink orcNPE

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5373
    
----
commit 97fd0c7687eff6f8b84516f4d8ab8268cab838b1
Author: Fabian Hueske <fhueske@...>
Date:   2017-12-12T11:09:14Z

    [FLINK-8230] [orc] Fix NPEs when reading nested columns.
    
    - fixes NPEs for null-valued structs, lists, and maps
    - fixes NPEs for repeating structs, lists, and maps
    - adds test for deeply nested data with nulls
    - adds test for columns with repeating values

----


---

Reply via email to