Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5396#discussion_r165317663
  
    --- Diff: 
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CompletedCheckpointTest.java
 ---
    @@ -19,58 +19,53 @@
     package org.apache.flink.runtime.checkpoint;
     
     import org.apache.flink.api.common.JobID;
    -import org.apache.flink.core.fs.Path;
     import org.apache.flink.core.testutils.CommonTestUtils;
     import org.apache.flink.runtime.jobgraph.JobStatus;
     import org.apache.flink.runtime.jobgraph.JobVertexID;
     import org.apache.flink.runtime.jobgraph.OperatorID;
     import org.apache.flink.runtime.state.SharedStateRegistry;
    -import org.apache.flink.runtime.state.StreamStateHandle;
    -import org.apache.flink.runtime.state.filesystem.FileStateHandle;
    +import org.apache.flink.runtime.state.testutils.EmptyStreamStateHandle;
    +import 
org.apache.flink.runtime.state.testutils.TestCompletedCheckpointStorageLocation;
     
     import org.junit.Rule;
     import org.junit.Test;
     import org.junit.rules.TemporaryFolder;
     
    -import java.io.File;
     import java.util.Collections;
     import java.util.HashMap;
     import java.util.Map;
     
     import static org.junit.Assert.assertEquals;
    +import static org.junit.Assert.assertFalse;
    +import static org.junit.Assert.assertTrue;
     import static org.mockito.Mockito.mock;
     import static org.mockito.Mockito.times;
     import static org.mockito.Mockito.verify;
     
    +/**
    + * Unit tests for the {@link CompletedCheckpoint}.
    + */
     public class CompletedCheckpointTest {
     
        @Rule
        public final TemporaryFolder tmpFolder = new TemporaryFolder();
     
    -   /**
    -    * Tests that persistent checkpoints discard their header file.
    -    */
        @Test
    -   public void testDiscard() throws Exception {
    -           File file = tmpFolder.newFile();
    -           assertEquals(true, file.exists());
    -
    +   public void registerStatesAtRegistry() {
    --- End diff --
    
    What's the reason for this change?


---

Reply via email to