Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r165341071
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
 ---
    @@ -197,7 +201,13 @@ public static TaskManagerServices fromConfiguration(
                final JobManagerTable jobManagerTable = new JobManagerTable();
     
                final JobLeaderService jobLeaderService = new 
JobLeaderService(taskManagerLocation);
    -           final TaskExecutorLocalStateStoresManager taskStateManager = 
new TaskExecutorLocalStateStoresManager();
    +
    +           final File taskExecutorLocalStateRootDir =
    +                   new 
File(taskManagerServicesConfiguration.getLocalStateRootDir(), 
LOCAL_STATE_SUB_DIRECTORY_ROOT);
    --- End diff --
    
    Are we giving the `TaskExecutorLocalStateStoresManager` a unique directory? 
What happens if multiple TMs run on the same machine? Will they use different 
directories?


---

Reply via email to