[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

[suez1224]

Github user suez1224 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5367#discussion_r165560235
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
 ---
    @@ -984,6 +987,63 @@ object ScalarOperators {
         }
       }
     
    +  def generateDot(codeGenerator: CodeGenerator,
    --- End diff --
    
    But I agree I should refactor the code in visitFieldAccess() to reuse it as 
much as possible.


---