Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5353#discussion_r165950588
  
    --- Diff: 
flink-docs/src/main/java/org/apache/flink/docs/rest/RestAPIDocGenerator.java ---
    @@ -285,11 +287,22 @@ private static String createMessageHtmlEntry(Class<?> 
messageClass, Class<?> emp
     
                        dispatcherGatewayRetriever = () -> null;
                        resourceManagerGatewayRetriever = () -> null;
    +                   transientBlobService = 
NoOpTransientBlobService.INSTANCE;
                        metricQueryServiceRetriever = path -> null;
                }
     
                private DocumentingDispatcherRestEndpoint() {
    -                   super(restConfig, dispatcherGatewayRetriever, config, 
handlerConfig, resourceManagerGatewayRetriever, executor, 
metricQueryServiceRetriever, NoOpElectionService.INSTANCE, 
NoOpFatalErrorHandler.INSTANCE);
    +                   super(
    +                           restConfig,
    +                           dispatcherGatewayRetriever,
    +                           config,
    +                           handlerConfig,
    +                           resourceManagerGatewayRetriever,
    +                           transientBlobService,
    --- End diff --
    
    I don't think we need these `static final` variables. Can just use 
`NoOpTransientBlobService.INSTANCE` as a constructor argument.


---

Reply via email to