[
https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355075#comment-16355075
]
ASF GitHub Bot commented on FLINK-8516:
---------------------------------------
Github user tweise commented on the issue:
https://github.com/apache/flink/pull/5393
@tzulitai Assignment and restore are orthogonal; this PR doesn't change
restore. I therefore don't see the need to add another migration test for it.
There is also no change to how the index is computed by default, it is just
that part of what happened earlier in `isThisSubtaskShouldSubscribeTo` is now
in the assigner. Should I add a (trivial) unit test that asserts that
`isThisSubtaskShouldSubscribeTo` applies modulus to assigner returned value
that falls outside the subtask index range?
> FlinkKinesisConsumer does not balance shards over subtasks
> ----------------------------------------------------------
>
> Key: FLINK-8516
> URL: https://issues.apache.org/jira/browse/FLINK-8516
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
> Affects Versions: 1.4.0, 1.3.2, 1.5.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
>
> The hash code of the shard is used to distribute discovered shards over
> subtasks round robin. This works as long as shard identifiers are sequential.
> After shards are rebalanced in Kinesis, that may no longer be the case and
> the distribution become skewed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
