[
https://issues.apache.org/jira/browse/FLINK-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359213#comment-16359213
]
ASF GitHub Bot commented on FLINK-8423:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5447
[FLINK-8423] OperatorChain#pushToOperator catch block may fail with NPE
## What is the purpose of the change
Fix the NPE when outputTag is null.
## Brief change log
Add when outputTag is not null, then do the catch block work.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: ( no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): ( no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no )
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (/ no)
- If yes, how is the feature documented? ( not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-8423
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5447.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5447
----
commit 65ac580ca5a3b4c78c954ff08eef9bedcb1e9713
Author: zhangminglei <zml13856086071@...>
Date: 2018-02-10T02:32:43Z
[FLINK-8423] OperatorChain#pushToOperator catch block may fail with NPE
----
> OperatorChain#pushToOperator catch block may fail with NPE
> ----------------------------------------------------------
>
> Key: FLINK-8423
> URL: https://issues.apache.org/jira/browse/FLINK-8423
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 1.4.0, 1.5.0
> Reporter: Chesnay Schepler
> Assignee: mingleizhang
> Priority: Critical
>
> {code}
> @Override
> protected <X> void pushToOperator(StreamRecord<X> record) {
> try {
> // we know that the given outputTag matches our OutputTag so
> the record
> // must be of the type that our operator (and Serializer)
> expects.
> @SuppressWarnings("unchecked")
> StreamRecord<T> castRecord = (StreamRecord<T>) record;
> numRecordsIn.inc();
> StreamRecord<T> copy =
> castRecord.copy(serializer.copy(castRecord.getValue()));
> operator.setKeyContextElement1(copy);
> operator.processElement(copy);
> } catch (ClassCastException e) {
> // Enrich error message
> ClassCastException replace = new ClassCastException(
> String.format(
> "%s. Failed to push OutputTag with id '%s' to
> operator. " +
> "This can occur when multiple OutputTags with
> different types " +
> "but identical names are being used.",
> e.getMessage(),
> outputTag.getId()));
> throw new ExceptionInChainedOperatorException(replace);
> } catch (Exception e) {
> throw new ExceptionInChainedOperatorException(e);
> }
> }
> {code}
> If outputTag is null (as is the case when no sideOutput was defined) the
> catch block will crash with a NullPointerException. This may happen if
> {{operator.processElement}} throws a ClassCastException.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
