Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5431#discussion_r167608001
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
 ---
    @@ -300,4 +587,12 @@ protected static ClusterConfiguration 
parseArguments(String[] args) {
        protected static Configuration loadConfiguration(ClusterConfiguration 
clusterConfiguration) {
                return 
GlobalConfiguration.loadConfiguration(clusterConfiguration.getConfigDir());
        }
    +
    +   /**
    +    * Execution mode of the {@link MiniDispatcher}.
    +    */
    +   public enum ExecutionMode {
    +           NORMAL, // waits until the job result has been served
    --- End diff --
    
    Should also be a Javadoc comment:
    ```
            /**
         * Execution mode of the {@link MiniDispatcher}.
         */
        public enum ExecutionMode {
                /**
                 * Waits until the job result has been served.
                 */
                NORMAL,
                /**
                 * Directly stops after the job has finished.
                 */
                DETACHED 
        }
    ```


---

Reply via email to