[ 
https://issues.apache.org/jira/browse/FLINK-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615250#comment-14615250
 ] 

ASF GitHub Bot commented on FLINK-2141:
---------------------------------------

Github user vasia commented on a diff in the pull request:

    https://github.com/apache/flink/pull/877#discussion_r33951120
  
    --- Diff: 
flink-staging/flink-gelly/src/main/java/org/apache/flink/graph/gsa/GatherSumApplyIteration.java
 ---
    @@ -367,6 +394,20 @@ public void join(Vertex<K, VV> vertex, Edge<K, EV> 
edge, Collector<Tuple2<K, Nei
                }
        }
     
    +   @SuppressWarnings("serial")
    +   @ForwardedFieldsSecond("f1->f0")
    --- End diff --
    
    I think this annotation is wrong. It's the first field that's forwarded 
(the edge source).
    If that's the case, can you please investigate why your tests don't catch 
this?


> Allow GSA's Gather to perform this operation in more than one direction
> -----------------------------------------------------------------------
>
>                 Key: FLINK-2141
>                 URL: https://issues.apache.org/jira/browse/FLINK-2141
>             Project: Flink
>          Issue Type: New Feature
>          Components: Gelly
>    Affects Versions: 0.9
>            Reporter: Andra Lungu
>            Assignee: Shivani Ghatge
>
> For the time being, a vertex only gathers information from its in-edges.
> Similarly to the vertex-centric approach, we would like to allow users to 
> gather data from out and all edges as well. 
> This property should be set using a setDirection() method.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to