Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/5441#discussion_r168447407
--- Diff:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/config/PropertyStrings.java
---
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.client.config;
+
+/**
+ * Strings used for key and values in an environment file.
+ */
+public final class PropertyStrings {
+
+ private PropertyStrings() {
+ // private
+ }
+
+ public static final String EXECUTION = "execution";
+
+ public static final String EXECUTION_TYPE = "type";
+
+ public static final String EXECUTION_TYPE_VALUE_STREAMING = "streaming";
+
+ public static final String EXECUTION_TYPE_VALUE_BATCH = "batch";
+
+ public static final String EXECUTION_MIN_STATE_RETENTION =
"min-idle-state-retention";
+
+ public static final String EXECUTION_MAX_STATE_RETENTION =
"max-idle-state-retention";
+
+ public static final String EXECUTION_PARALLELISM = "parallelism";
+
+ public static final String EXECUTION_MAX_PARALLELISM =
"max-parallelism";
+
+ public static final String EXECUTION_RESULT_MODE = "result-mode";
+
+ public static final String EXECUTION_RESULT_MODE_VALUE_CHANGELOG =
"changelog";
+
+ public static final String EXECUTION_RESULT_MODE_VALUE_TABLE = "table";
+
+ public static final String DEPLOYMENT = "deployment";
--- End diff --
I think we should leave this generic. It might also contain things like
YARN application id or whatever there might come in the future.
---
