[ https://issues.apache.org/jira/browse/FLINK-8666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16366117#comment-16366117 ]
ASF GitHub Bot commented on FLINK-8666: --------------------------------------- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5499 [FLINK-8666] [test] Use testDispatcherConfig in MiniCluster ## What is the purpose of the change Using the AkkaUtils#testDispatcherConfig reduces the number of started threads. This effectively decreases the resource foot print of the MiniCluster. This PR is based on #5498. ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink nonBlockingShutdown Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5499.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5499 ---- commit 1a077c7bb7d6240e86171dbbbd77e43668a7fe6c Author: Till Rohrmann <trohrmann@...> Date: 2018-02-15T17:43:39Z [FLINK-8664] [rest] Change RpcEndpoint#TerminationFuture value type to Void commit 7911549b935ab91b5b762db621966bc0c252501c Author: Till Rohrmann <trohrmann@...> Date: 2018-02-15T16:58:35Z [hotfix] Remove unused method MiniCluster#waitUntilTaskManagerRegistrationsComplete commit c18d71bacd4194e7d6d4501226a2ed29f042ec5e Author: Till Rohrmann <trohrmann@...> Date: 2018-02-15T17:14:55Z [hotfix] Don't fail LeaderContender and Listener when closing EmbeddedLeaderService commit 090b4d7d5537df6300f7a552542f4a9d2a3c79ae Author: Till Rohrmann <trohrmann@...> Date: 2018-02-15T17:22:21Z [hotfix] Fix checkstyle violations in RpcEndpoint commit 81c57923052f15bf848d0fc803ec5ef2cb548398 Author: Till Rohrmann <trohrmann@...> Date: 2018-02-15T18:19:48Z [FLINK-8665] [rest] Let RpcEndpoint#postStop return completion future The RpcEndpoint#postStop method returns a CompletableFuture<Void> which is completed once all post stop actions have completed. The termination future of the respective RpcEndpoint is only completed afterwards. commit 66662030818187fda4e5f97eb93c64cfb21dd53e Author: Till Rohrmann <trohrmann@...> Date: 2018-02-15T17:07:49Z [FLINK-8666] [test] Use testDispatcherConfig in MiniCluster Using the AkkaUtils#testDispatcherConfig reduces the number of started threads. This effectively decreases the resource foot print of the MiniCluster. ---- > Use AkkaUtils#testDispatcherConfig in MiniCluster > ------------------------------------------------- > > Key: FLINK-8666 > URL: https://issues.apache.org/jira/browse/FLINK-8666 > Project: Flink > Issue Type: Improvement > Components: Tests > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Minor > Labels: flip-6 > Fix For: 1.5.0 > > > By using the {{AkkaUtils#testDispatcherConfig}} for the {{AkkaRpcServices}} > used by the {{MiniCluster}}, we can drastically reduce the number of started > threads. This will improve the resource foot print of the {{MiniCluster}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)