[ 
https://issues.apache.org/jira/browse/FLINK-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16367409#comment-16367409
 ] 

ASF GitHub Bot commented on FLINK-8659:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5495
  
    It's hard to know the actual changes from the existing savepoint it case. I 
created a new history by tweezing apart the copying and the actual 
modifications: 
https://github.com/aljoscha/flink/tree/finish-pr-5495-broadcast-migration-test. 
I first only copy the existing test to create the new one, then I apply the 
changes. Could you update your PR to that?
    
    Another thing is that in general reusing code is good but in this test you 
should simply copy all the user code, the new test refers to classes in the old 
test which will make it hard if we want to remove the old test at some point 
and also makes things hard with serialisation, as you noticed. What do you 
think?


> Add migration tests for Broadcast state.
> ----------------------------------------
>
>                 Key: FLINK-8659
>                 URL: https://issues.apache.org/jira/browse/FLINK-8659
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 1.5.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>            Priority: Major
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to