[ https://issues.apache.org/jira/browse/FLINK-8732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371597#comment-16371597 ]
ASF GitHub Bot commented on FLINK-8732: --------------------------------------- GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5548 [FLINK-8732] [flip6] Cancel ongoing scheduling operation ## What is the purpose of the change Keeps track of ongoing scheduling operations in the ExecutionGraph and cancels them in case of a concurrent cancel, suspend or fail call. This makes sure that the original cause for termination is maintained. cc: @GJL ## Verifying this change - Added `ExecutionGraphSchedulingTest#testEagerSchedulingWithSlotTimeout` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable) You can merge this pull request into a Git repository by running: $ git pull https://github.com/tillrohrmann/flink cancelSchedulingOperation Alternatively you can review and apply these changes as the patch at: https://github.com/apache/flink/pull/5548.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5548 ---- commit 431346f2c460076d90a0ce6b538609f78b0f6788 Author: Till Rohrmann <trohrmann@...> Date: 2018-02-21T14:57:50Z [FLINK-8732] [flip6] Cancel ongoing scheduling operation Keeps track of ongoing scheduling operations in the ExecutionGraph and cancels them in case of a concurrent cancel, suspend or fail call. This makes sure that the original cause for termination is maintained. ---- > Cancel scheduling operation when cancelling the ExecutionGraph > -------------------------------------------------------------- > > Key: FLINK-8732 > URL: https://issues.apache.org/jira/browse/FLINK-8732 > Project: Flink > Issue Type: Bug > Components: Distributed Coordination > Affects Versions: 1.5.0 > Reporter: Till Rohrmann > Assignee: Till Rohrmann > Priority: Major > Labels: flip-6 > Fix For: 1.5.0 > > > With the Flip-6 changes and the support for queued scheduling, the > {{ExecutionGraph}} must be able to handle cancellation calls when it is not > yet fully scheduled. This is for example the case when waiting for new > containers. > A cancellation will cancel all {{Executions}}. As a result, available slots > can get assigned to other {{Executions}} (already canceled). Since the slot > cannot be assigned to this slot because it's already canceled, this can fail > the overall eager scheduling operation. The scheduling result callback will > then trigger a global fail operation. This can happen before all > {{Executions}} have been released and, thus, when the {{ExecutionGraph}} is > still in the state {{CANCELLING}}. The result is that the {{ExecutionGraph}} > goes into the state {{FAILING}} and then {{FAILED}}. > In order to solve this problem, I propose to keep track of the scheduling > operation and cancelling the result future when a concurrent {{suspend}}, > {{cancel}} or {{fail}} call happens. -- This message was sent by Atlassian JIRA (v7.6.3#76005)